Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokenization_code_llama_fast.py #26576

Merged

Conversation

andyl98
Copy link
Contributor

@andyl98 andyl98 commented Oct 3, 2023

What does this PR do?

Fixes the issue: #26575

Before submitting

Who can review?

@ArthurZucker

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Let's add a test! 😉

@andyl98
Copy link
Contributor Author

andyl98 commented Oct 4, 2023

Added some unit tests :)

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this catch! Looks good to me

@ArthurZucker ArthurZucker merged commit 65aabaf into huggingface:main Oct 6, 2023
18 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

helboukkouri pushed a commit to helboukkouri/transformers that referenced this pull request Oct 16, 2023
* Update tokenization_code_llama_fast.py

* Update test_tokenization_code_llama.py

* Update test_tokenization_code_llama.py
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* Update tokenization_code_llama_fast.py

* Update test_tokenization_code_llama.py

* Update test_tokenization_code_llama.py
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
* Update tokenization_code_llama_fast.py

* Update test_tokenization_code_llama.py

* Update test_tokenization_code_llama.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants