[docstring] Fix docstring for LlamaConfig
#26685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ydshieh can you please review this |
|
@abzdel i already passed all 7 CI test cases after following your recommendation. Thank you alex! |
Awesome! Keep me in the loop if anything else comes up. |
ydshieh
reviewed
Oct 9, 2023
ydshieh
reviewed
Oct 9, 2023
reformat of the file to prevent script issues
fix formatting after docstring review
ydshieh
approved these changes
Oct 9, 2023
|
Hi, could you run |
|
@ydshieh roger that! i will run |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
rerun `make fixup` after reformatting
|
@ydshieh already finished running |
ydshieh
approved these changes
Oct 10, 2023
helboukkouri
pushed a commit
to helboukkouri/transformers
that referenced
this pull request
Oct 16, 2023
* Your commit message here * fix LlamaConfig docstring * run make fixup * fix formatting after review reformat of the file to prevent script issues * rerun make fixup after reformat
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
* Your commit message here * fix LlamaConfig docstring * run make fixup * fix formatting after review reformat of the file to prevent script issues * rerun make fixup after reformat
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
* Your commit message here * fix LlamaConfig docstring * run make fixup * fix formatting after review reformat of the file to prevent script issues * rerun make fixup after reformat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #26638 by fixing a typo in docstring of
LlamaConfigBefore submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ydshieh @abzdel
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.