Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MistralIntegrationTest OOM #26754

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Fix MistralIntegrationTest OOM #26754

merged 3 commits into from
Oct 12, 2023

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Oct 12, 2023

What does this PR do?

Fix MistralIntegrationTest OOM

@slow
def test_model_7b_generation(self):
EXPECTED_TEXT_COMPLETION = (
"""My favourite condiment is mayonnaise. I love it on sandwiches, in salads, on burgers"""
"""My favourite condiment is 100% ketchup. I love it on everything. I’m not a big"""
Copy link
Collaborator Author

@ydshieh ydshieh Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is given by the contributor: we don't know their environment. On T4, this is the first time we make this test run.

@ydshieh ydshieh requested a review from LysandreJik October 12, 2023 09:53
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 12, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@LysandreJik LysandreJik merged commit db5e0c3 into main Oct 12, 2023
3 checks passed
@LysandreJik LysandreJik deleted the fix_MistralIntegrationTest branch October 12, 2023 10:31
helboukkouri pushed a commit to helboukkouri/transformers that referenced this pull request Oct 16, 2023
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants