Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PerceiverModelIntegrationTest::test_inference_masked_lm #26760

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix PerceiverModelIntegrationTest::test_inference_masked_lm #26760

merged 1 commit into from
Oct 12, 2023

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Oct 12, 2023 •
edited
Loading

What does this PR do?

The PR #23909 changed the result of vocab_size of

tokenizer = PerceiverTokenizer.from_pretrained("deepmind/language-perceiver")

from 262 to 256, but the logit has shape [1, 2048, 262].

Let's use len here.

To reproduce:

from transformers import PerceiverTokenizer

tokenizer = PerceiverTokenizer.from_pretrained("deepmind/language-perceiver")
# 256 on `2da88537` but `262` on one commit before (`835b0a05`)
print(tokenizer.vocab_size)

@ydshieh ydshieh requested a review from LysandreJik October 12, 2023 13:26
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 12, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

LysandreJik
LysandreJik approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct change!

@LysandreJik LysandreJik merged commit a243cdc into main Oct 12, 2023
3 checks passed
@LysandreJik LysandreJik deleted the fix_perceiver branch October 12, 2023 15:43
helboukkouri pushed a commit to helboukkouri/transformers that referenced this pull request Oct 16, 2023
@ydshieh @helboukkouri
Fix PerceiverModelIntegrationTest::test_inference_masked_lm (huggin…
fac1827 
…gface#26760)

fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
@ydshieh @blbadger
Fix PerceiverModelIntegrationTest::test_inference_masked_lm (huggin…
0e26b2a 
…gface#26760)

fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
@ydshieh @EduardoPach
Fix PerceiverModelIntegrationTest::test_inference_masked_lm (huggin…
d0b5491 
…gface#26760)

fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ydshieh @HuggingFaceDocBuilderDev @LysandreJik