Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate pipeline_tutorial.md to chinese #26954

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Translate pipeline_tutorial.md to chinese #26954

merged 5 commits into from
Oct 23, 2023

Conversation

jiaqiw09
Copy link
Contributor

@jiaqiw09 jiaqiw09 commented Oct 20, 2023 •
edited
Loading

What does this PR do?

Part of #26803

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests? not necessary

Who can review?

@stevhliu

@jiaqiw09
Copy link
Contributor Author

@stevhliu

I just updated my translation work. Here is a guileline during my translation:

  • Keep some terminology in English format. Those workds appears in amounts of class files or other documents. I think it's better to keep it in original format rather give a chinese translation.

@jiaqiw09 jiaqiw09 closed this Oct 20, 2023
@jiaqiw09 jiaqiw09 reopened this Oct 20, 2023
@jiaqiw09 jiaqiw09 changed the title Translate docs to chinese Translate pipeline_tutorial.md to chinese Oct 20, 2023
stevhliu
stevhliu reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that makes sense to me! Last step is to add this file to the toctree so it gets built :)

docs/source/zh/pipeline_tutorial.md
对于视觉任务，使用[`pipeline`] 几乎是相同的。

指定您的任务并将图像传递给分类器。图像可以是链接、本地路径或base64编码的图像。例如，下面显示的是哪种品种的猫？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the image link here:

Suggested change
![pipeline-cat-chonk](https://huggingface.co/datasets/huggingface/documentation-images/resolve/main/pipeline-cat-chonk.jpeg)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix it. Thanks for your reviw

@jiaqiw09
Copy link
Contributor Author

@stevhliu Thansk for your review. I just fix these two problems. Would you mind having a check again?
And for another PR of preprocessing.md, I will update it after this PR is merged. Both PRs changes _toctree.yml, there may be some merge conflict problem.
Best

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

stevhliu
stevhliu approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks again!

@stevhliu stevhliu merged commit f09a081 into huggingface:main Oct 23, 2023
3 checks passed
@jiaqiw09 jiaqiw09 deleted the translate_docs_to_chinese branch October 24, 2023 15:17
staghado pushed a commit to staghado/transformers that referenced this pull request Oct 24, 2023
@jiaqiw09 @staghado
Translate pipeline_tutorial.md to chinese (huggingface#26954)
63c177a 
* update translation of pipeline_tutorial and preprocessing(Version1.0)

* update translation of pipeline_tutorial and preprocessing(Version2.0)

* update translation docs

* update to fix problems mentioned in review

---------

Co-authored-by: jiaqiw <wangjiaqi50@huawei.com>
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
@jiaqiw09 @EduardoPach
Translate pipeline_tutorial.md to chinese (huggingface#26954)
98c2dde 
* update translation of pipeline_tutorial and preprocessing(Version1.0)

* update translation of pipeline_tutorial and preprocessing(Version2.0)

* update translation docs

* update to fix problems mentioned in review

---------

Co-authored-by: jiaqiw <wangjiaqi50@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevhliu stevhliu stevhliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiaqiw09 @HuggingFaceDocBuilderDev @stevhliu