Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed broken link #27560

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fixed broken link #27560

merged 1 commit into from
Nov 17, 2023

Conversation

VpkPrasanna
Copy link
Contributor

@VpkPrasanna VpkPrasanna commented Nov 17, 2023 •
edited
Loading

What does this PR do?

Fixed the broken link for flatten method of dataset process

Fixes # (issue)
Screenshot from 2023-11-17 18-05-17

the link is 404 due to URL is wrong with .html at the end.
Screenshot from 2023-11-17 18-06-20

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu and @MKhalusova

MKhalusova
MKhalusova approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@MKhalusova MKhalusova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for noticing the issue and adding the fix! LGTM

@stevhliu stevhliu merged commit 638d499 into huggingface:main Nov 17, 2023
8 checks passed
@VpkPrasanna VpkPrasanna deleted the dataset_process_flatten branch November 17, 2023 17:54
wgifford pushed a commit to namctin/transformers that referenced this pull request Nov 17, 2023
@VpkPrasanna @wgifford
fixed broken link (huggingface#27560)
f4d6975
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
@VpkPrasanna @EduardoPach
fixed broken link (huggingface#27560)
8209b21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKhalusova MKhalusova MKhalusova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VpkPrasanna @MKhalusova @stevhliu