FIX [Trainer / tags]: Fix trainer + tags when users do not pass "tags" to trainer.push_to_hub()
#29009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackyon
pushed a commit
to hackyon/transformers
that referenced
this pull request
Feb 15, 2024
…ags"` to `trainer.push_to_hub()` (huggingface#29009) * fix trainer tags * add test
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
…ags"` to `trainer.push_to_hub()` (#29009) * fix trainer tags * add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title - and fixes: hiyouga/LLaMA-Factory#2474 (comment) raised by @hiyouga
Indeed, we should always push tags if there are any that are saved on the model. Currently the logic is wrong, as it pushes the tags only if
"tags"is passed totrainer.push_to_hub(), in fact we should always push the tag ifmodel.add_model_tagshas been called, regardless iftagsis passed or not inpush_to_hubcc @amyeroberts