Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modeling_flava.py #30198

Closed
wants to merge 1 commit into from
Closed

Update modeling_flava.py #30198

wants to merge 1 commit into from

Conversation

jmonas
Copy link

@jmonas jmonas commented Apr 11, 2024

What does this PR do?

Deletes duplicate softmax in FLAVA self-attention

Fixes # NA

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

duplicate softmax in FLAVA self-attention
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 eek! Thanks for spotting and fixing

Could you run the model tests, and update any of the slow tests if necessary:

RUN_SLOW=1 pytest tests/models/flava

@huggingface huggingface deleted a comment from github-actions bot May 13, 2024
@amyeroberts
Copy link
Collaborator

Hi @jmonas, any update on this?

Regarding running the slow model tests, we've just added a new feature which enables running them on our github runners as CI. I've added the run-slow tag which should enable this on this PR. To trigger a run, all you need to do is push an empty commit with the message: [run-slow] flava (I'll also need to approve the workflow).

Would be great to have this fix merged in!

Copy link

github-actions bot commented Jun 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants