Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test loading generation config with safetensor weights #31550

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

gante
Copy link
Member

@gante gante commented Jun 22, 2024

What does this PR do?

Fix #29522

This PR changes the model used in a generation config loading test to a model that a) is used on other tests b) has a generation config. The purpose of the test is to check that the generation config is loaded correctly with the model (which broke in the past)

The model used for the test is a dummy model, and it has empty weights that break when we load the model with device_map="auto" (because we can call .to with empty weights when the source is a meta device).

@gante gante requested a review from amyeroberts June 22, 2024 12:04
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ArthurZucker ArthurZucker merged commit 4c2538b into huggingface:main Jul 9, 2024
17 of 19 checks passed
@gante gante deleted the fix_29522 branch July 9, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate tests failing with updated safetensors' weights
4 participants