Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistral ONNX export #31696

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Jun 28, 2024

The ONNX torchscript export fails after #30642 as exclude_mask |= ... gets mapped to aten::__ior_ which is not exportable. aten::bitwise_or is.

Using torch.bitwise_or(exclude_mask, second_mask, out=exclude_mask) breaks as well the ONNX export so using the inplace version of the operator instead.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@fxmarty
Copy link
Contributor Author

fxmarty commented Jun 28, 2024

keras CI looks broken

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as compile is still supported?

Copy link
Contributor

@zhenglongjiepheonix zhenglongjiepheonix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me , it seems still compile-compatible

@fxmarty fxmarty merged commit 57d7594 into huggingface:main Jul 2, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants