Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save_pretrained: use tqdm when saving checkpoint shards from offloaded params #31856

Merged

Conversation

kallewoof
Copy link
Contributor

@kallewoof kallewoof commented Jul 9, 2024

Even at 9B, doing a save with partially CPU offloaded tensors can take up to 30 seconds. Doing a 70B model can take 5-10 minutes depending on how much VRAM you have around. This adds a progress bar to give the user some visual feedback whenever there are offloaded params.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding! LGTM as we do the same for loading checkpoint shards

@amyeroberts amyeroberts merged commit cffa2b9 into huggingface:main Jul 9, 2024
20 checks passed
@kallewoof kallewoof deleted the 202407-save-pretrained-tqdm branch July 9, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants