Processor accepts any kwargs #31889
Merged
Processor accepts any kwargs #31889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
approved these changes
Jul 10, 2024
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Jul 19, 2024
* accept kwargs in processors * return unused kwargs * fix tests * typo * update the other way
MHRDYN7
pushed a commit
to MHRDYN7/transformers
that referenced
this pull request
Jul 23, 2024
* accept kwargs in processors * return unused kwargs * fix tests * typo * update the other way
zucchini-nlp
added a commit
to zucchini-nlp/transformers
that referenced
this pull request
Jul 24, 2024
* accept kwargs in processors * return unused kwargs * fix tests * typo * update the other way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes VLMs' processors so that they can accept any kwarg, but will raise a warning if any of the passed kwargs is not used.
Currently, if a new kwargs is added to processors (e.g. chat template), the updated files on the hub won't work with older version of transformers because older versions didn't have a new kwargs in their
__init__. This change will facilitate future PRs that introduce new kwargs in processors, and we'll be able to add any feature without problemsNote: PR doesn't modify processors of image-only or audio-only models, and actually some of them already support
**kwargsat init (e.g. Clip) due to the deprecation cycle of "feature_extractor" kwarg.