Fixed log messages that are resulting in TypeError due to too many arguments
#32017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sai-Suraj-27
changed the title
log messages that are resulting in TypeErrors due to too many argumentslog messages that are resulting in TypeError due to too many arguments
amyeroberts
approved these changes
Jul 17, 2024
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Jul 19, 2024
…arguments (huggingface#32017) * Fixed log messages that are resulting in TypeErrors due to too many arguments. * Removed un-necessary imports.
MHRDYN7
pushed a commit
to MHRDYN7/transformers
that referenced
this pull request
Jul 23, 2024
…arguments (huggingface#32017) * Fixed log messages that are resulting in TypeErrors due to too many arguments. * Removed un-necessary imports.
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Jul 24, 2024
…arguments (huggingface#32017) * Fixed log messages that are resulting in TypeErrors due to too many arguments. * Removed un-necessary imports.
itazap
pushed a commit
that referenced
this pull request
Jul 25, 2024
…arguments (#32017) * Fixed log messages that are resulting in TypeErrors due to too many arguments. * Removed un-necessary imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
FutureWarningshould be used insidewarnings.warn(), but at some places i see that it is used inside logging statements. So, I fixed them and some of the log statements have comma (,) between strings, which leads to considering them as multiple positional arguments, resulting inTypeErrors.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@amyeroberts