Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TorchAOHfQuantizer #32306
Add TorchAOHfQuantizer #32306
Changes from 7 commits
5782f38
9b6b688
85ea6fe
fe4eddd
e2d0478
a2284df
25f132b
89ec2ce
91b4223
597d8ad
3c893a8
78313eb
130d2df
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's maybe mention it supports compile ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But one can serialize the state dict with
quantized_model.state_dict()
and then use it later right? I'd prefer to have this information included as a workaround.Also, can we provide a small table noting the expected memory and latency savings here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah state_dict works locally, but I'm not sure how to get this work with the
load_pretrained
save_pretrained
API. we are adding serialization support for both safetensor and non-safetensor thoughyeah we have some numbers here: https://github.com/pytorch/ao/tree/main/torchao/quantization#benchmarks, I can add it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am guessing that the type of the layer under torchao does not change the linear layer? As in any other quantization methods we check against the quantized liner type!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, torchao only modifies the weight tensor and not the nn.Linear module. So we don't need to check against the quantized linear type.