Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore keys on validate_rope #33753

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Conversation

zucchini-nlp
Copy link
Member

What does this PR do?

Fixes #33401. Adds ignore_keys argument when checking received keys and adds mrope_section in qwen2-vl config file as a key we should ignore

I'll open PRs on the hub to change rope type from mrope to default, but until ten decided to leave the comment. For curious users who might open up more issues trying to find why we do manual modifications on rope type :)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Could you add tests that ensures that:

  1. A warning is printed when an unneeded key is sent
  2. The warning isn't printed when ignore_keys is correctly set

Thanks!

@HuggingFaceDocBuilderDev

Hey! 🤗 Thanks for your contribution to the transformers library!

Before merging this pull request, slow tests CI should be triggered. To enable this:

  • Add the run-slow label to the PR
  • When your PR is ready for merge and all reviewers' comments have been addressed, push an empty commit with the command [run-slow] followed by a comma separated list of all the models to be tested, i.e. [run_slow] model_to_test_1, model_to_test_2
    • If the pull request affects a lot of models, put at most 10 models in the commit message
  • A transformers maintainer will then approve the workflow to start the tests

(For maintainers) The documentation for slow tests CI on PRs is here.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot 🙌

Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing it 🙏

@zucchini-nlp zucchini-nlp merged commit 061c2c4 into huggingface:main Oct 4, 2024
19 checks passed
ArthurZucker pushed a commit that referenced this pull request Oct 7, 2024
* ignore keys on check rope

* add tests

* fix tests, so maybe better leave at logger lvl
NielsRogge pushed a commit to NielsRogge/transformers that referenced this pull request Oct 21, 2024
* ignore keys on check rope

* add tests

* fix tests, so maybe better leave at logger lvl
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
* ignore keys on check rope

* add tests

* fix tests, so maybe better leave at logger lvl
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
* ignore keys on check rope

* add tests

* fix tests, so maybe better leave at logger lvl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Latest version cannot load Qwen2-VL model config correctly.
4 participants