-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore keys on validate_rope
#33753
Ignore keys on validate_rope
#33753
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! Could you add tests that ensures that:
- A warning is printed when an unneeded key is sent
- The warning isn't printed when
ignore_keys
is correctly set
Thanks!
Hey! 🤗 Thanks for your contribution to the Before merging this pull request, slow tests CI should be triggered. To enable this:
(For maintainers) The documentation for slow tests CI on PRs is here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for fixing it 🙏
* ignore keys on check rope * add tests * fix tests, so maybe better leave at logger lvl
* ignore keys on check rope * add tests * fix tests, so maybe better leave at logger lvl
* ignore keys on check rope * add tests * fix tests, so maybe better leave at logger lvl
* ignore keys on check rope * add tests * fix tests, so maybe better leave at logger lvl
What does this PR do?
Fixes #33401. Adds ignore_keys argument when checking received keys and adds
mrope_section
in qwen2-vl config file as a key we should ignoreI'll open PRs on the hub to change rope type from mrope to default, but until ten decided to leave the comment. For curious users who might open up more issues trying to find why we do manual modifications on rope type :)