Ignore unsupported kwarg in ProcessorMixin call #34285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a processor kwarg that is not supported by any modality is passed to a ProcessorMixin call, it is added to CommonKwargs whether or not it is supported by the ProcessorMixin's CommonKwargs object.
This means that any kwargs passed to a processor call will that is not supported by any modality will still be added to all modality kwargs, which can lead to errors. Example:
gives
And a
TypeError
After this fix:
Who can review?
@molbap