Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bert] remove hard-coded pad token id #3793

Merged
merged 1 commit into from
Apr 16, 2020
Merged

[Bert] remove hard-coded pad token id #3793

merged 1 commit into from
Apr 16, 2020

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Apr 14, 2020 •
edited
Loading

tiny change to remove hard coded pad_token_id in Bert.

@patrickvonplaten patrickvonplaten force-pushed the get_pad_token_id_in_bert_from_config branch from e5e5aa8 to 7f102ea Compare April 14, 2020 18:45
@julien-c
Copy link
Member

LGTM

thomwolf
thomwolf approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@thomwolf thomwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed

@patrickvonplaten patrickvonplaten merged commit a5b2494 into huggingface:master Apr 16, 2020
@monologg monologg mentioned this pull request Apr 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomwolf thomwolf thomwolf approved these changes

@LysandreJik LysandreJik Awaiting requested review from LysandreJik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickvonplaten @julien-c @thomwolf