Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_ddpo_demo #1129

Merged
merged 1 commit into from
Dec 23, 2023
Merged

fix_ddpo_demo #1129

merged 1 commit into from
Dec 23, 2023

Conversation

zhangsibo1129
Copy link
Contributor

In examples/scripts/ddpo.py , the AestheticScorer.mlp loads weights to cuda device by default

self.mlp.load_state_dict(state_dict)
state_dict = torch.load(cached_path)

which throws an error for non-cuda devices, so loading weights on cpu first

self.mlp.load_state_dict(state_dict, map_location=torch.device('cpu'))
state_dict = torch.load(cached_path)

and then copy to target device

if is_npu_available():
    scorer = scorer.npu()
elif is_xpu_available():
    scorer = scorer.xpu()
else:
    scorer = scorer.cuda()

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the ddpo demo !

@younesbelkada
Copy link
Contributor

@zhangsibo1129 can you run the styling checks? make precommit

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@younesbelkada younesbelkada merged commit e0dec27 into huggingface:main Dec 23, 2023
9 checks passed
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants