Change device access order for speedup of calculating metrics in DPOTrainer #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younesbelkada
approved these changes
Dec 29, 2023
|
great thank you for the fix! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when calculating metrics in
DPOTrainer, the values are moved to the CPU and the mean is calculated. However, when doing this, the cost of moving the values to the CPU is very large.So I changed the device order to improve speed. Below are the
torch profilerresults before and after changing the order in my experiment.As shown in the figure, the operation to move to the CPU has a similar cost to the forward of the model.
After making the change, the time taken has decreased significantly.