Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPO] average_log_prob when loss is IPO #1265

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

kashif
Copy link
Collaborator

@kashif kashif commented Jan 22, 2024

so that the beta is not dependent on the sequence length with IPO

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kashif kashif requested a review from edbeeching January 24, 2024 08:46
Copy link
Collaborator

@edbeeching edbeeching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. LGTM!

@kashif kashif merged commit 29d439a into huggingface:main Jan 24, 2024
2 of 9 checks passed
@kashif kashif deleted the ipo-avg branch January 24, 2024 11:18
@kmn1024 kmn1024 mentioned this pull request Jan 31, 2024
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
* average_log_prob when loss is IPO

* updated docs with the fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants