Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transformers version checking for Python < 3.8 #1363

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Fix transformers version checking for Python < 3.8 #1363

merged 1 commit into from
Feb 27, 2024

Conversation

samuki
Copy link
Contributor

@samuki samuki commented Feb 25, 2024

To be consistent with the existing code and maintain compatibility for environments running Python versions earlier than 3.8, this pull request includes a minor adjustment to the is_transformers_greater_than function.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks !

@younesbelkada younesbelkada merged commit cf68d87 into huggingface:main Feb 27, 2024
9 checks passed
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants