Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPO] fix memory leak due to retained value #1531

Merged
merged 1 commit into from
Apr 12, 2024
Merged

[CPO] fix memory leak due to retained value #1531

merged 1 commit into from
Apr 12, 2024

Conversation

kashif
Copy link
Collaborator

@kashif kashif commented Apr 12, 2024

fixes #1526

@kashif kashif requested a review from lewtun April 12, 2024 13:03
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

lewtun
lewtun approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM

@kashif kashif merged commit 363369a into main Apr 12, 2024
9 checks passed
@kashif kashif deleted the kashif-patch-1 branch April 12, 2024 13:32
kashif added a commit to kashif/trl that referenced this pull request Apr 12, 2024
@kashif
[CPO] fix memory leak due to retained value (huggingface#1531)
51736f3
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
@kashif
[CPO] fix memory leak due to retained value (huggingface#1531)
a966d01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewtun lewtun lewtun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kashif @HuggingFaceDocBuilderDev @lewtun