Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ppov2_trainer tensorboard logging bug #1836

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

DZ9
Copy link
Contributor

@DZ9 DZ9 commented Jul 16, 2024

Tensorboard log fails because current code doesn't update global step.

  • before:
    image

  • after this PR:
    image

  • test command

python examples/scripts/ppo/ppo.py \
    --learning_rate 3e-6 \
    --output_dir ./output \
    --per_device_train_batch_size 1 \
    --gradient_accumulation_steps 1 \
    --total_episodes 100 \
    --model_name_or_path Qwen2/Qwen2-0.5B-Instruct \
    --non_eos_penalty \
    --sft_model_path Qwen2/Qwen2-0.5B-Instruct \
    --reward_model_path Qwen2/Qwen2-0.5B-Instruct \
    --report_to tensorboard \
    --local_rollout_forward_batch_size 1 \
    --logging_strategy steps \
    --logging_steps 1 

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kashif kashif merged commit 052a8e1 into huggingface:main Jul 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants