[Online-DPO] num_generation_per_prompt is fixed #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
kashif
changed the title
|
Important: seems like eos penalty had an error - scores = torch.where(contain_eos_token, scores, args.penalty_reward_value)
+ scores = torch.where(contain_eos_token, args.penalty_reward_value, scores) |
kashif
changed the title
qgallouedec
reviewed
Aug 6, 2024
| @@ -287,14 +288,13 @@ def repeat_generator(): | |||
| del logits, all_logprob | |||
| torch.cuda.empty_cache() | |||
|
|
|||
| with torch.no_grad(): | |||
There was a problem hiding this comment.
Is it because ref model is in eval mode that you don't need to use the context?
qgallouedec
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
num_generation_per_promptis always 2 for the online DPO casewith torch.no_grad():