Fix logits compuation in KTO trainer prediction step #2050
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
There is a bug in the following few lines of code in
kto_trainer.py
This assumes that the values in the
logits_dict
are tensors, but they are not. These values are computed inget_batch_loss_metrics
where the the logits are averaged and.item()
is called on the resulting tensor to get afloat
.This causes the following error when running a KTO training:
What does this PR do?
logits_dict
as floatsAttributeError: 'float' object has no attribute 'unsqueeze'
during the evaluation phase of a KTO training