Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc fixes and comments #2073

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Minor doc fixes and comments #2073

merged 5 commits into from
Sep 16, 2024

Conversation

qgallouedec
Copy link
Member

@qgallouedec qgallouedec commented Sep 16, 2024

  • Remove docs/source/trainer.mdx as autodocs are all in respective trainer sections.
  • Add comment for import utils conversion
  • Add a missing ` in GKD trainer doc
  • Sort toc tree

@qgallouedec qgallouedec requested a review from lewtun September 16, 2024 14:23
Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes - LGTM!


> [!WARNING]
> Make sure that `attn_implementation="flash_attention_2"` when training [Gemma models](https://huggingface.co/models?other=gemma2). Otherwise you will encounter NaNs in the logits due to the [soft capping technique](https://huggingface.co/blog/gemma2#soft-capping-and-attention-implementations) adopted by this architecture.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@qgallouedec qgallouedec merged commit 41fe228 into main Sep 16, 2024
4 of 10 checks passed
@qgallouedec qgallouedec deleted the misc branch September 16, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants