-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👈 Add tokenizer
arg back and add deprecation guidelines
#2348
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
tokenizer
arg back and deprecation and backward compatibility guidelinestokenizer
arg back and add deprecation guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for enabling backwards compatibility @qgallouedec! The PR LGTM and the new docs are really well written 🔥
@@ -256,3 +256,30 @@ That's how `make test` is implemented (without the `pip install` line)! | |||
|
|||
You can specify a smaller set of tests to test only the feature | |||
you're working on. | |||
|
|||
### Deprecation and Backward Compatibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice documentation!
Beautiful! 🔥 |
What does this PR do?
#2162 introduced a breaking change on all trainers except DPO and SFT (
tokenizer
arg replaced byprocessing_class
). We've had feedback that this change was too abrupt, so we're reintroducing this argument with an extended timeline for its removal and also clarifying our removal strategy.This PR will be part of a patch release for v0.12
Here is the proposed schedule depending of the usage for each trainer:
cc @muellerzr
Related: #2290 #2226 #2207 #2218
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.