Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧮 Fix max_steps calculation in RLOOTrainer #2433

Merged
merged 1 commit into from
Dec 3, 2024
Merged

🧮 Fix max_steps calculation in RLOOTrainer #2433

merged 1 commit into from
Dec 3, 2024

Conversation

qgallouedec
Copy link
Member

What does this PR do?

Fixes #2401

I'm not entirely sure why it works but the problem is gone for varying batch size, rloo k, world size, grad accumulation step.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qgallouedec qgallouedec requested review from kashif and lewtun December 3, 2024 19:17
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kashif
Copy link
Collaborator

kashif commented Dec 3, 2024

is it because we have effectively 2 x bigger batches from the chosen and rejected pairs?

@qgallouedec
Copy link
Member Author

Probably..., merging as it seems to resolve the issue.

@qgallouedec qgallouedec merged commit 52201d3 into main Dec 3, 2024
13 of 14 checks passed
@qgallouedec qgallouedec deleted the fix-rloo branch December 3, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RLOO Trainer Stopping After 1 Epoch
3 participants