Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using batched generate in sentiment scripts #249

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Using batched generate in sentiment scripts #249

merged 1 commit into from
Mar 27, 2023

Conversation

GauravVirmani
Copy link
Contributor

What does this PR do?

Fixes #246

Using batched generate in all the 3 sentiment tuning example scripts: gpt2-sentiment.py, gpt2-sentiment_peft.py and t5-sentiment.py

cc @lvwerra @younesbelkada

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 24, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

younesbelkada
younesbelkada approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!
I can confirm all the scripts work fine:

Thanks a lot for this amazing contribution 🔥

@younesbelkada younesbelkada merged commit b5cce0d into huggingface:main Mar 27, 2023
@younesbelkada younesbelkada mentioned this pull request Mar 27, 2023
Closed
@GauravVirmani GauravVirmani deleted the batch-gen-example branch March 28, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesbelkada younesbelkada younesbelkada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

why not use bacth for model generate
3 participants
@GauravVirmani @HuggingFaceDocBuilderDev @younesbelkada