Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arguments description #298

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Fix arguments description #298

merged 3 commits into from
Apr 12, 2023

Conversation

lvzii
Copy link
Contributor

@lvzii lvzii commented Apr 11, 2023

Fix arguments description, output_max_length was descripted as "the learning rate"

younesbelkada
younesbelkada approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for you awesome contribution!
I left one suggestion

examples/stack_llama/scripts/rl_training.py Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 11, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@lvwerra lvwerra merged commit d1c7529 into huggingface:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesbelkada younesbelkada younesbelkada approved these changes

@lvwerra lvwerra lvwerra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lvzii @HuggingFaceDocBuilderDev @lvwerra @younesbelkada