Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dataloader typo in ppo_trainer.py #389

Merged
merged 2 commits into from
May 30, 2023
Merged

fix dataloader typo in ppo_trainer.py #389

merged 2 commits into from
May 30, 2023

Conversation

LZY-the-boys
Copy link
Contributor

dataloader must be a torch.utils.data.Dataset: dataloader should be dataset

@LZY-the-boys
fix typo in ppo_trainer.py
94fca1a 
`dataloader must be a torch.utils.data.Dataset`: `dataloader` should be `dataset`
@LZY-the-boys
Merge pull request #1 from LZY-the-boys/fix-dataloader-typo-patch-1
47fc922 
fix typo in ppo_trainer.py
lvwerra
lvwerra approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 26, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@lvwerra lvwerra merged commit 86c1174 into huggingface:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvwerra lvwerra lvwerra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LZY-the-boys @HuggingFaceDocBuilderDev @lvwerra