Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds github actions and dummy test #55

Merged
merged 7 commits into from
Dec 21, 2022
Merged

Conversation

edbeeching
Copy link
Collaborator

@edbeeching edbeeching commented Dec 21, 2022

To run tests locally

make test

Tests run on github actions for linux & mac python versions 3.7-3.9

@edbeeching edbeeching requested a review from lvwerra December 21, 2022 09:38
@edbeeching edbeeching marked this pull request as ready for review December 21, 2022 09:38
Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding this @edbeeching! Minor comment about envs/versions.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@edbeeching edbeeching merged commit 2b6dae8 into master Dec 21, 2022
@kashif kashif deleted the tests-and-github-actions branch December 12, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants