Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version should have dev0 unless it is a release version #99

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Version should have dev0 unless it is a release version #99

merged 2 commits into from
Jan 23, 2023

Conversation

mishig25
Copy link

@mishig25 mishig25 commented Jan 23, 2023 •
edited
Loading

Version should have dev0 unless it is a release version

@lvwerra
Copy link
Member

lvwerra commented Jan 23, 2023

Thanks for adding. Could you also update it in trl/__init__.py for consistency?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 23, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@mishig25
Copy link
Author

Did so !

lvwerra
lvwerra approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@mishig25
Copy link
Author

@lvwerra please feel free to merge it 👍

@lvwerra lvwerra merged commit 92c0617 into huggingface:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvwerra lvwerra lvwerra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mishig25 @lvwerra @HuggingFaceDocBuilderDev