Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the git library #11

Closed
hughbris opened this issue May 18, 2022 · 4 comments
Closed

Replace the git library #11

hughbris opened this issue May 18, 2022 · 4 comments
Labels

Comments

@hughbris
Copy link
Owner

sebastian/git is deprecated and there are better alternatives that will allow us to simplify our code and the enrich the UI (eg. #10).

Mentioned in #4 too.

@pamtbaau
Copy link
Collaborator

The one mentioned in #4 (https://github.com/symplify/git-wrapper) requires PHP >= 8. Does that pose a limitation?

@hughbris
Copy link
Owner Author

Oh yeah it does for me ATM, unfortunately.

@hughbris
Copy link
Owner Author

I did another quick search. Only found ones I'd starred before. Lots of noise in these searches of course. Here are some findings.

Git.php: The docs are so basic and the open issues are so old that I am scared off.

git-php: feature-rich, simple, documented, maintained. worth following up.

Some more are listed in a similar GitSync issue but none suitable and it's reasonably obvious why in each case.

I like the idea of not requiring PHP exec permission in a library because it opens the plugin up to being used in more secure setups. The less environment requirements the better.

@hughbris
Copy link
Owner Author

hughbris commented Apr 9, 2023

Effectively completed in 941afbc and merged into develop in f52dbc0.

@hughbris hughbris closed this as completed Apr 9, 2023
@hughbris hughbris unpinned this issue Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants