Updating jQuery throws JS errors

[hughbris]

After e04f724, users who want to run an updated jQuery using the conformance.jquery theme option will have a Javascript error in their consoles: Uncaught TypeError: e.indexOf is not a function thrown in /system/assets/jquery/jquery-3.x.min.js:2:85207 (love those minified file errors).

The only effect I've noticed on the theme functioning so far (in FF) has been that the dropdown menus don't drop. It's very likely there are more errors.

This makes the new option useless, unless you customise your template partials/asset-jquery.html.twig to make this error go away. And if you know how to do that, please share your genius here and I will make this issue go away.

Here is the back story:

After receiving these scary looking alerts from Github's friendly sweepers, I looked into them. They didn't seem likely to leave deployments of the theme vulnerable. I still wanted to fix them if it was simple.

CVE-2019-11358
CVE-2020-23064
CVE-2015-9251
CVE-2020-11022

I swapped out the line where the jQuery JS asset is included and simply added 'jquery'. This is where the JS runtime error was introduced. This has not affected my other official repository themes, Minimaxing and Landed, when clearing those advisories in the same way.

[hughbris]

• remove links to this issue in code and docs when it is closed

[kittyfishfrommars]

Please see pull request bugfix: #15 updating jquery throws js errors #17

The immediate cause was a mismatch in the loading behaviour in line 30 and line 50.

Since it is now safe to drop the conformity check from solarize.yaml, I have done so.
This forces the theme to always use jQuery v.3.7.1 from its theme folder /vendor/js