fix: Hotfixed dodgy base name in DI, added test to prevent future reg…

…ression
hughesjs · Mar 13, 2023 · c1c04c0 · c1c04c0
1 parent 09cdc05
commit c1c04c0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/...kSdk.Microsoft.Extensions.DependencyInjection.Tests/DependencyInjectionExtensionsTests.cs b/...kSdk.Microsoft.Extensions.DependencyInjection.Tests/DependencyInjectionExtensionsTests.cs
@@ -1,5 +1,6 @@
 using CelesTrakSdk.Microsoft.Extensions.DependencyInjection.DependencyInjection;
 using CelesTrakSdk.Public.Clients;
+using CelesTrakSdk.Public.Models.Enums;
 using Microsoft.Extensions.DependencyInjection;
 using Shouldly;
 
@@ -19,4 +20,17 @@ public void CanGetClientFromServiceProvider()
 
 		client.ShouldNotBeNull();
 	}
+
+	[Fact]
+	public async Task CanGetResultFromResolvedClient()
+	{
+		IServiceCollection collection = new ServiceCollection();
+		_ = collection.AddCelesTrakServices();
+
+		ServiceProvider   provider = collection.BuildServiceProvider();
+		ICelesTrakClient? client   = provider.GetService<ICelesTrakClient>();
+
+		client.ShouldNotBeNull();
+		await Should.NotThrowAsync(async () => await client.GetRecords(SatCatRecordQueryType.Group, "STATIONS"));
+	}
 }
diff --git a/...osoft.Extensions.DependencyInjection/DependencyInjection/DependencyInjectionExtensions.cs b/...osoft.Extensions.DependencyInjection/DependencyInjection/DependencyInjectionExtensions.cs
@@ -8,7 +8,7 @@ public static class DependencyInjectionExtensions
 {
 	public static IServiceCollection AddCelesTrakServices(this IServiceCollection services)
 	{
-		services.AddHttpClient<ICelesTrakClient, CelesTrakClient>(h => h.BaseAddress = new("https://celestrak.org/satcat/records.php"));
+		services.AddHttpClient<ICelesTrakClient, CelesTrakClient>(h => h.BaseAddress = new("https://celestrak.org/"));
 
 		return services;
 	}