Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About #40

Merged
merged 52 commits into from
Jan 10, 2021
Merged

About #40

merged 52 commits into from
Jan 10, 2021

Conversation

apreshill
Copy link
Collaborator

@apreshill apreshill commented Jan 8, 2021

cc @maelle

Addresses issue #8 and some of issue #29

preview: https://about--cranky-lalande-e3373f.netlify.app/about/

@maelle
Copy link

maelle commented Jan 8, 2021

In the post list, I'd expect the second post to come before the first one?

content/about/index.md Outdated Show resolved Hide resolved
description: A blog template for Hugo developed by Formspree and available for free.
description: "A blog template for Hugo developed by Formspree and available for free."
author: "Emily Cooper"
headline: "Hi, my name is Emily Cooper.<br> Nice to meet you."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
headline: "Hi, my name is Emily Cooper.<br> Nice to meet you."
headline: |
Hi, my name is Emily Cooper.
Nice to meet you."

not sure about the number of space needed before the lines. I was just thinking it might be nice to not have the br?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it still needs a <br> to create the line break though

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right or maybe one more empty line?

@apreshill apreshill merged commit b183774 into master Jan 10, 2021
@apreshill apreshill deleted the about branch January 10, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants