Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a _custom.sass so that people can make small css adjustments easily #93

Closed
poVoq opened this issue Aug 7, 2023 · 5 comments · Fixed by #103
Closed

Add a _custom.sass so that people can make small css adjustments easily #93

poVoq opened this issue Aug 7, 2023 · 5 comments · Fixed by #103

Comments

@poVoq
Copy link
Contributor

poVoq commented Aug 7, 2023

If you add a emtpy _custom.sass to the theme then people using the theme can overwrite it in their root /assets/sass/ directory and make small css adjustments themselves.

Thanks!
@github-actions github-actions bot added the Stale label Aug 17, 2023
Repository owner deleted a comment from github-actions bot Aug 22, 2023
@hugo-sid hugo-sid removed the Stale label Aug 22, 2023
@hugo-sid
Copy link
Owner

Thanks for the idea @poVoq.

I have a slightly different thought. One can override any style sheet by creating a file with same name in /assets/sass/ directory.

In that case do you think we need _custom.sass ?

@poVoq
Copy link
Contributor Author

poVoq commented Aug 22, 2023

Yes, but then you need to copy over the entire sass file and keep track of changes you made when updating etc.

If you add an empty _custom.sass to the theme, the person overriding it has a nice self contained file that only includes the modifications and nothing else.

@hugo-sid
Copy link
Owner

Thanks for the explanation @poVoq. That makes sense.

hugo-sid added a commit that referenced this issue Aug 26, 2023
@hugo-sid
feat: add _custom.scss to enable small csschanges easily closes #93
d878c35
@hugo-sid hugo-sid mentioned this issue Aug 26, 2023
Merged
5 tasks
@hugo-sid hugo-sid mentioned this issue Aug 26, 2023
Merged
@poVoq
Copy link
Contributor Author

poVoq commented Aug 26, 2023

Seems to work as intended. Thanks!

@hugo-sid
Copy link
Owner

hugo-sid commented Dec 6, 2023 •
edited
Loading

@poVoq, thanks for this idea. I plan to allow theme users to include custom HTML markup before the end of <head>
& before the end of <body> using similar technique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(main): release 1.8.0 hugo-sid/hugo-blog-awesome
2 participants
@poVoq @hugo-sid