Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Language Selector accessibility #131

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix: Language Selector accessibility #131

merged 1 commit into from
Oct 3, 2023

Conversation

c-reetz
Copy link
Contributor

@c-reetz c-reetz commented Oct 3, 2023

Fix: Accesibility rules, regains 100% accesibility score, read more: https://dequeuniversity.com/rules/axe/4.7/select-name

What problem does this PR solve?

Fixes the accessibility parameter on the select for language selector

Is this PR adding a new feature? No

Fixes the accessibility paramterer on the select for language selector, thus regaining 100% accessibility score on PagesInsight for desktop, follows the rules laid by: https://dequeuniversity.com/rules/axe/4.7/select-name and adds an aria-label="" so it doesn't add extra text on the page itself.

Is this PR related to any issue or discussion? No

PR Checklist

  • [ x] I have verified that the code works as described/as intended.
  • This change adds a social icon which has a permissive license to use it.
  • [x ] This change does not include any external library/resources.
  • [ x] This change does not include any unrelated scripts (e.g. bash and python scripts).
  • [ x] I have enabled maintainer edits for this PR.

Fix: Accesibility rules, regains 100% accesibility score, read more:
https://dequeuniversity.com/rules/axe/4.7/select-name
@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for hugo-blog-awesome ready!

Name Link
🔨 Latest commit 546204e
🔍 Latest deploy log https://app.netlify.com/sites/hugo-blog-awesome/deploys/651c027a19b8dc0008335d51
😎 Deploy Preview https://deploy-preview-131--hugo-blog-awesome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Owner

@hugo-sid hugo-sid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @c-reetz, for improving accessibility of language selector.

@hugo-sid hugo-sid merged commit 5f52bb2 into hugo-sid:main Oct 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants