Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add french language #178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add french language #178

wants to merge 1 commit into from

Conversation

ShiiFu
Copy link

@ShiiFu ShiiFu commented Mar 18, 2024

What problem does this PR solve?

Missing language.

Is this PR adding a new feature?

Add french language

Is this PR related to any issue or discussion?

No

PR Checklist

  • I have verified that the code works as described/as intended.
  • This change adds a social icon which has a permissive license to use it.
  • This change does not include any external library/resources.
  • This change does not include any unrelated scripts (e.g. bash and python scripts).
  • I have enabled maintainer edits for this PR.

Copy link

This pull request has conflicts with the base branch, please resolve those so that we can review the pull request.

@github-actions github-actions bot added the conflicts This PR has conflicts which must be resolved before it can be reviewed. label Mar 18, 2024
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for hugo-blog-awesome failed.

Name Link
🔨 Latest commit e5523c2
🔍 Latest deploy log https://app.netlify.com/sites/hugo-blog-awesome/deploys/66033daabe415c00099477d4

Repository owner deleted a comment from github-actions bot Mar 21, 2024
@hugo-sid
Copy link
Owner

hugo-sid commented Mar 21, 2024

@ShiiFu, thanks for adding support for French language.

There are some conflicts in the exampleSite/config.toml file.

I guess a simple rebase against the main branch of this repository will resolve the conflicts.

Feel free to let me know if you encounter any issues while resolving conflicts.

Copy link

Conflicts have been resolved! 🎉 A maintainer will soon review the pull request.

@github-actions github-actions bot removed the conflicts This PR has conflicts which must be resolved before it can be reviewed. label Mar 26, 2024
Copy link

This PR exceeds the recommended size of 300 lines (counting both additions & deletions). Kindly ensure that you are NOT addressing multiple issues in one PR. We recommend you to create atomic PRs which focus on a single change.

Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants