-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding PDF Shortcut #672
Adding PDF Shortcut #672
Conversation
pdf-js is sered locally to preserve privacy and comply with GDPR
There are a ton of useless: |
One possible improvement could be adding a "download" button to the top menu Are these 3 things ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you @MarionMoseby. Can you please add a guide for the short code?.
Issue
Adding PDF Shortcut #522
Fixes #522
Description
Adds the latest version of pdf-js (from: https://mozilla.github.io/pdf.js/) to the static/js folder, and the embed-pdf shortcode (maybe could be renamed to pdf?) to layouts/shortcodes. This shorcode was mainly taken from anvithks/hugo-embed-pdf-shortcode, as is implied to preserve copyright. Maybe an issue should be opened in his repo to let him now? (not necessary but nice)
Test Evidence
A minimal reproducible example can be reproduced like so:
hugo serve
The result should be like so: