Let safe signals work with nullable parameters.

hugopl · Jun 21, 2024 · 77e8207 · 77e8207
1 parent 12749f5
commit 77e8207
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/spec/safe_signal_spec.cr b/spec/safe_signal_spec.cr
@@ -65,4 +65,9 @@ describe "Save signals" do
     GC.collect
     obj_ref.value.should eq(nil)
   end
+
+  it "validate nilable parameters" do
+    Gio::SimpleAction::ActivateSignal.new(GObject::Object.new, "").validate_params(::Union(GLib::Variant, ::Nil))
+
+  end
 end
diff --git a/src/generator/signal_gen.cr b/src/generator/signal_gen.cr
@@ -48,10 +48,11 @@ module Generator
 
           arg = arg_strategy.arg
           arg_type_info = arg.type_info
-          nullmark = " | Nil" if arg.nullable?
 
-          s << to_identifier(arg.name) << " : "
-          s << to_crystal_type(arg_type_info, include_namespace: true) << ".class" << nullmark << ','
+          s << to_identifier(arg.name) << " : ("
+          s << to_crystal_type(arg_type_info, include_namespace: true)
+          s << " | Nil" if arg.nullable?
+          s << ").class,"
         end
       end
     end