Merge pull request #52 from hugovk/convert-to-pytest

.pre-commit-config.yaml

@@ -1,19 +1,19 @@
 repos:
   - repo: https://github.com/asottile/pyupgrade
-    rev: v2.29.0
+    rev: v2.29.1
     hooks:
       - id: pyupgrade
         args: [--py37-plus]
 
   - repo: https://github.com/psf/black
-    rev: 21.9b0
+    rev: 21.11b1
     hooks:
       - id: black
         args: [--target-version=py37]
         exclude: ^html/
 
   - repo: https://github.com/PyCQA/isort
-    rev: 5.9.3
+    rev: 5.10.1
     hooks:
       - id: isort
 
@@ -39,7 +39,7 @@ repos:
       - id: trailing-whitespace
 
   - repo: https://github.com/asottile/setup-cfg-fmt
-    rev: v1.18.0
+    rev: v1.20.0
     hooks:
       - id: setup-cfg-fmt
 

setup.cfg

@@ -35,7 +35,7 @@ python_requires = >=3.7
 include_package_data = True
 package_dir = =src
 setup_requires =
-    setuptools_scm
+    setuptools-scm
 
 [options.packages.find]
 where = src

src/osmviz/animation.py

@@ -86,7 +86,7 @@ def get_bounding_box(self):
         be implemented if this SimViz is passed in as one of the
         scene_viz's (as opposed to an actor_viz).
         """
-        raise Exception("UNIMPLEMENTED")
+        raise NotImplementedError
 
     def get_time_interval(self):
         """
@@ -95,7 +95,7 @@ def get_time_interval(self):
         visualization object.
         May return (-Inf, Inf) to indicate that it is always present.
         """
-        raise Exception("UNIMPLEMENTED")
+        raise NotImplementedError
 
     def set_state(self, sim_time, get_xy):
         """
@@ -104,15 +104,15 @@ def set_state(self, sim_time, get_xy):
         This should be stored internally, for subsequent calls to
         methods such as drawToSurface or mouseIntersect.
         """
-        raise Exception("UNIMPLEMENTED")
+        raise NotImplementedError
 
     def draw_to_surface(self, surf):
         """
         To be overridden.
         Draws this viz on the supplied surface, according to its
         internal state.
         """
-        raise Exception("UNIMPLEMENTED")
+        raise NotImplementedError
 
     def get_drawing_order(self):
         """
@@ -140,7 +140,7 @@ def mouse_intersect(self, mouse_x, mouse_y):
         Note that for Simulation purposes, if get_label() returns
         None then this method does not need to be implemented.
         """
-        raise Exception("UNIMPLEMENTED")
+        raise NotImplementedError
 
 
 class TrackingViz(SimViz):

src/osmviz/manager.py

@@ -64,21 +64,21 @@ def paste_image(self, img, xy):
         Given an already-loaded file, paste it into the internal image
         at the specified top-left coordinate.
         """
-        raise Exception("UNIMPLEMENTED")
+        raise NotImplementedError
 
     def load_image_file(self, image_file):
         """
         To be overridden.
         Loads specified image file into image object and returns it.
         """
-        raise Exception("UNIMPLEMENTED")
+        raise NotImplementedError
 
     def create_image(self, width, height):
         """
         To be overridden.
         Create and return image with specified dimensions
         """
-        raise Exception("UNIMPLEMENTED")
+        raise NotImplementedError
 
     # END OF TO BE OVERRIDDEN #
 

test/unit/test_image_manager.py

@@ -0,0 +1,20 @@
+"""
+Unit tests for ImageManager
+"""
+import pytest
+
+from osmviz.manager import ImageManager
+
+
+def test_unimplemented():
+    # Arrange
+    image_manager = ImageManager()
+    # Dummy parameters
+    dp1 = None
+    dp2 = None
+
+    # Act / Assert
+    with pytest.raises(NotImplementedError):
+        image_manager.paste_image(dp1, dp2)
+        image_manager.load_image_file(dp1)
+        image_manager.create_image(dp1, dp2)