Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.8 #32

Merged
merged 8 commits into from
Oct 17, 2019
Merged

Add support for Python 3.8 #32

merged 8 commits into from
Oct 17, 2019

Conversation

hugovk
Copy link
Owner

@hugovk hugovk commented Oct 15, 2019

Plus:

  • Remove Python 2 warning
  • use extras_require for test dependencies
  • update pre-commit
  • lint and test using GitHub Actions

@hugovk hugovk added the enhancement New feature or request label Oct 15, 2019
@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   41.59%   41.59%           
=======================================
  Files           3        3           
  Lines         327      327           
=======================================
  Hits          136      136           
  Misses        191      191
Impacted Files Coverage Δ
src/osmviz/animation.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b63de3...ddfcfc8. Read the comment docs.

@hugovk
Copy link
Owner Author

hugovk commented Oct 17, 2019

Before adding pre-commit caching to Travis, tox lint takes 48.47s, whole lint job takes 1m 22s.

With cold cache: 45.03s, 1m 23s.

With warm cache: 8.94s, 43 sec.

@hugovk hugovk merged commit 2089ae7 into master Oct 17, 2019
@hugovk hugovk deleted the add-3.8 branch October 17, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant