Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visualize_heap #77

Merged
merged 5 commits into from
Jul 10, 2022
Merged

Fix visualize_heap #77

merged 5 commits into from
Jul 10, 2022

Conversation

hugsy
Copy link
Owner

@hugsy hugsy commented Jul 4, 2022

Description/Motivation/Screenshots

Fixed several major bugs that prevented visualize-heap to work correctly.

image

Related issues/PRs:

Depends on:

cc @0xricksanchez

How Has This Been Tested ?

"Tested" indicates that the PR works and the unit test (i.e. make test) run passes without issue.

  • x86-32
  • x86-64
  • ARM
  • AARCH64
  • MIPS
  • POWERPC
  • SPARC
  • RISC-V

Checklist

  • My PR was done against the dev branch, not main.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@hugsy hugsy linked an issue Jul 4, 2022 that may be closed by this pull request
@0xricksanchez
Copy link

0xricksanchez commented Jul 4, 2022

Seems like something along the way of refactoring has gone missing when testing gef/heap_bugz with this branch here.
For the exact setup refer to hugsy/gef#854 (comment)

image

@hugsy
Copy link
Owner Author

hugsy commented Jul 5, 2022

Tests will fail until hugsy/gef#869 is merged.

@hugsy hugsy merged commit 35eaf9d into dev Jul 10, 2022
@hugsy hugsy deleted the fix_visualize_heap branch July 10, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

visualize-heap is broken
2 participants