prompt ascii changed #1013
Closed
prompt ascii changed #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Coverage Update
To this point, this PR:
|
|
The prompt is non ascii. If it doesn't work, it's a problem with your terminal, not with GEF. You need to enable utf-8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch is the solution to a problem that I faced while running gef for gdb on cloud servers (I use them to use different CPU Architectures). For the last 6 months, I have been facing this problem and today was the day when I finally got the motivation to track down the problem. I am pretty sure that many gef users face the problem of getting a Unicode Encode Error and not using the goodness of gef tool. This was something that I solved in this patch.
The Unicode Encode Error occurs right from the start, the moment when gef is installed. Now this is not in every case, like gef was working fine with my local machine but fails in certain systems due to the error. This one-word change solved the problem of this error. A beginner who is trying to run gef first time on a machine that would throw this error might face an issue like this and end up not using the power of gef. The prompt arrow was causing the Unicode Encode Error. The Prompt had an error with the ASCII character "➤" and I replaced it with ">" which is common in the case of most of the terminals. This small change ran the gef, that I had abandoned for more than 6 months.
We all need to use the goodness of gef and beginners must start by using gef. But this small error of prompt pointer makes the tool unusable, and hence this will cause the user base to go down. By changing the prompt (I know that the earlier prompt was cool), the error can be fixed and the debugger is ready to be used and learned by a beginner. The practical usage is more useful. I don't want any other person to stop using this tool for more than 6 months due to a single character error.