-
-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min-size and max-size filter to heap chunks command #1025
Conversation
Hi @r12f
It is not blocking, we're all just very busy lately. Yes, disregard this failure, I thought that issue was fixed but GHActions continues being annoying af. I will review your PR during the week. 👋 |
sounds perfect! thanks a lot for confirming @hugsy ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good PR with just a few minor things to change and we're good !
thanks a lot for reviewing the PR! the comments are addressed now :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Added a comment about maybe avoiding an if around should process by checking once at the top. Might not make sense logically, I didn't look too closely. If you disagree, that's fine and @hugsy can go ahead and merge with my blessing.
Woot! thanks a lot for the review! |
Description
This change adds
--min-size
and--max-size
filter to heap chunks command.With heap summary, we can quickly use
--min-size
and--max-size
filter to find some sample chunks for further analysis.Here are the screenshots as demo: