Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate arguments passed to vmmap #1085

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Evaluate arguments passed to vmmap #1085

merged 1 commit into from
Apr 20, 2024

Conversation

clubby789
Copy link
Contributor

@clubby789 clubby789 commented Apr 18, 2024

Description

Attempts to parse and eval an argument passed to vmmap.

This makes vmmap $rip, for example, work.

This is useful as it is easier to look up the memory section a pointer contained in a register/variable points to. It's also more consistent with commands like dereference

image

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

Copy link

🤖 Coverage update for 62bb686 🟢

Old New
Commit d211658 62bb686
Score 71.564% 71.564% (0)

Copy link

🤖 Coverage update for bb47c27 🟢

Old New
Commit d211658 bb47c27
Score 71.564% 71.564% (0)

Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR.
Please add also documentation to vmmap

Copy link

🤖 Coverage update for 156a9d7 🟢

Old New
Commit 399f457 156a9d7
Score 71.564% 71.564% (0)

@hugsy hugsy merged commit 6a2ecce into hugsy:main Apr 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants