Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Add a way to append values to optional arguments in parse_arguments decorator #1122

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

ValekoZ
Copy link
Collaborator

@ValekoZ ValekoZ commented Jun 24, 2024

Add support for the append action for ArgumentParser in the parse_arguments decorator on optional arguments.

This makes us able to support this:

command --arg 1 --arg 2 --arg 3

And get [1, 2, 3] as the arg value.

This CL is required to make changes to #1120 before merging.

Copy link

🤖 Coverage update for fd5b5e1 🟢

Old New
Commit c450a2d fd5b5e1
Score 71.6798% 71.6798% (0)

Copy link

🤖 Coverage update for fd5b5e1 🔴

Old New
Commit c450a2d fd5b5e1
Score 71.6798% 71.6649% (-0.0149)

Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tiny fix
Thanks for the PR tho, I was certain we already had that

gef.py Outdated Show resolved Hide resolved
Co-authored-by: crazy hugsy <hugsy@users.noreply.github.com>
@ValekoZ ValekoZ requested a review from hugsy June 24, 2024 15:56
Copy link

🤖 Coverage update for 84b2afd 🟢

Old New
Commit c450a2d 84b2afd
Score 71.6798% 71.6798% (0)

Copy link

🤖 Coverage update for 84b2afd 🔴

Old New
Commit c450a2d 84b2afd
Score 71.6798% 71.6649% (-0.0149)

@hugsy hugsy merged commit 6ddd780 into main Jun 24, 2024
6 checks passed
@hugsy hugsy deleted the parse_arguments_append_optional branch June 24, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants