Update break commands #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
reviewed
Aug 24, 2021
docs/commands/pie.md
Outdated
| ``` | ||
| gef➤ pie <sub_commands> | ||
| ``` | ||
| The `pie` command provides a useful way to set breakpoint to a PIE enabled |
There was a problem hiding this comment.
Let's fix up the wording.
There was a problem hiding this comment.
Is it better now?
docs/commands/pie.md
Outdated
| ``` | ||
| The `pie` command provides a useful way to set breakpoint to a PIE enabled | ||
| binary. `pie` command then provides what we call "PIE breakpoints". A PIE | ||
| breakpoint is just a virtual breakpoint which will be turned to a real |
There was a problem hiding this comment.
I don't think we need this level of detail the. Maybe just mention that it's handy to resolve to addresses that aren't static.
docs/commands/pie.md
Outdated
| ``` | ||
|
|
||
| ### `pie info` command ### | ||
|
|
||
| Since PIE breakpoint is not real breakpoint, this command provide a way to observe the | ||
| state of all PIE breakpoints. | ||
| Since a PIE breakpoint is not a real breakpoint, this command provide a way to |
There was a problem hiding this comment.
typo provide -> provides
docs/commands/pie.md
Outdated
|
|
||
| You can ignore VNum argument to get info of all PIE breakpoints. | ||
| You can ommit the VNum argument to get the info on all PIE breakpoints. |
gef.py
Outdated
| @@ -4499,21 +4499,20 @@ def do_invoke(self, argv): | |||
|
|
|||
| @register_command | |||
| class PieBreakpointCommand(GenericCommand): | |||
| """Set a PIE breakpoint.""" | |||
| """Set a PIE breakpoint at an offset to the target binaries base address.""" | |||
|
All good for merge AFAIC after @Grazfather 's suggestions are added |
Grazfather
reviewed
Aug 24, 2021
docs/commands/pie.md
Outdated
| The VNum is the virtual number, which is the number of the PIE breakpoint. The Num is the | ||
| number of the according real breakpoint number in gdb. Address is the PIE breakpoint's | ||
| address. | ||
| VNum stands for virtual number and is used to numerate the PIE breakpoints and |
There was a problem hiding this comment.
enumerate.
Then new sentence before "Num is.."
docs/commands/pie.md
Outdated
|
|
||
| You can ignore VNum argument to get info of all PIE breakpoints. | ||
| You can omit the VNum argument to get the info on all PIE breakpoints. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update break commands
Description/Motivation/Screenshots
This PR is part of #693 and covers the following points:
name-breakcmd by usingparse_address()now.name-breakdocs.pie breakpointtakes an offset (or symbol) as an argument and not an absolute address.pie breakpoint.piecommands documentation and usage instructions.How Has This Been Tested?
make testChecklist
devbranch, notmaster.